The porch floor metal was probably added in the 1980s and was fit around the trim instead of going behind it. I`ll flash it properly and also shim under the tin on the floor to move the water away from this wall, then atrip and reinstall the siding, caulk, and Paint. If you can keep an old house dry it will last a lot longer.